[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix netdev detection on RHEL6x versions of qemu

On Wed, 2011-06-01 at 13:38 -0600, Eric Blake wrote:

> Meanwhile, as to your question about the libvirt testsuit including RHEL
> qemu -help output: that merely proves that libvirt is properly parsing
> the available -help output, and not that libvirt is inferring any
> special properties of RHEL qemu that were not directly advertised in -help.

I appreciate your input but I feel that it suffers from the same problem
you complain of.

Libvirt is not properly parsing the help message as the decisions it
makes means that the attach-device derived functions do not work with
the qemu supplied on a major platform.

The actual fault is with 12.x standard qemu advertising netdev when it
doesn't have it. Libvirt is using  'special properties not directly
advertised in -help' to infer that 12.x netdev is broken.

So really you're special casing the standard qemu, and actually you'd
probably be better removing that special case altogether and letting the
standard qemu fail on attach (which frankly less people will be using),
and feeding the problem upstream to the qemu developer to fix the 12.x
branch help message.

I'll leave it with you guys at that.

The patch is on the list for anybody suffering the same issues I am.


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]