[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix auditing of disk hotunplug operations



On 06/02/2011 07:58 AM, Daniel P. Berrange wrote:
> From: "Daniel P. Berrange" <berrange redhat com>
> 
> The qemuAuditDisk calls in disk hotunplug operations were being
> passed 'ret >= 0', but the code which sets ret to 0 was not yet
> executed, and the error path had already jumped to the 'cleanup'
> label. This meant hotunplug failures were never audited, and
> hotunplug success was audited as a failure
> 
> * src/qemu/qemu_hotplug.c: Fix auditing of hotunplug
> ---
>  src/qemu/qemu_hotplug.c |    7 +++++--
>  1 files changed, 5 insertions(+), 2 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]