[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix error reporting with virDomainBlockStats on inactive guest



On Thu, Jun 02, 2011 at 08:26:50AM -0600, Eric Blake wrote:
> On 06/02/2011 07:58 AM, Daniel P. Berrange wrote:
> > From: "Daniel P. Berrange" <berrange redhat com>
> > 
> > Pull the check on virDomainIsActive upto top of the QEMU
> 
> s/upto/up to/
> 
> > impl of virDomainBlockStats so that is is reported promptly
> > 
> > * src/qemu/qemu_driver.c: Check if guest is active immediately
> > ---
> >  src/qemu/qemu_driver.c |    6 ++++++
> >  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> This means that we are now checking multiple times (once on entry for
> immediate effect even if migration is under way, and again after
> acquiring job condition if migration is not under way), but that
> shouldn't hurt.
> 
> However, you also need to do the same thing for qemuDomainGetBlockInfo,
> since both methods were given the same control flow during commit 18c2a592.

qemuDomainGetBlockInfo is actually worse. Previously qemuDomainGetBlockInfo
worked just fine on inactive guests, but now it will throw an error :-(


Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]