[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 06/10] remote: avoid leak on failure



On Thu, Jun 02, 2011 at 05:07:58PM -0600, Eric Blake wrote:
> Detected by Coverity.  Only possible in OOM situations.
> 
> * daemon/remote.c (remoteDispatchDomainScreenshot): Plug leak.
> ---
>  daemon/remote.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/daemon/remote.c b/daemon/remote.c
> index 2a32ee8..49058f2 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -1453,6 +1453,7 @@ remoteDispatchDomainScreenshot(struct qemud_server *server ATTRIBUTE_UNUSED,
>      *mime_p = strdup(mime);
>      if (*mime_p == NULL) {
>          virReportOOMError();
> +        VIR_FREE(mime_p);
>          goto cleanup;
>      }

ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]