[libvirt] [PATCH 03/10] storage: avoid memory leak
Eric Blake
eblake at redhat.com
Fri Jun 3 14:37:12 UTC 2011
On 06/02/2011 06:38 PM, Daniel Veillard wrote:
> On Thu, Jun 02, 2011 at 05:07:55PM -0600, Eric Blake wrote:
>> Coverity detected that options was being set by strdup but never
>> freed. But why even bother with an options variable? The options
>> parameter never changes! Leak present since commit 44948f5b (0.7.0).
>>
>> This function could probably be rewritten to take better advantage
>> of virCommand, but that is more invasive.
>>
>
> Okay it seems we unconditionally set this option for glusterfs, but
> I'm still confused by the initial author intent there. It would be good
> if someone else could double check, this looks good but I'm not 100%
> sure and glusterfs is not used that often.
Thanks for the reviews. I'm pushing this as-is (along with the rest of
the ack'd series); if someone more familiar with glusterfs speaks up, we
can revisit that post-release as part of the more invasive rewrite to
use virCommand instead of virRun.
Now off to round 2 of coverity analysis :)
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110603/08397977/attachment-0001.sig>
More information about the libvir-list
mailing list