[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] security driver: ignore EINVAL when chowning an image file



On 06/03/2011 10:04 AM, Laine Stump wrote:
> This fixes:
> 
>   https://bugzilla.redhat.com/show_bug.cgi?id=702044
>   https://bugzilla.redhat.com/show_bug.cgi?id=709454
> 
> Both of these complain of a failure to use an image file that resides
> on a read-only NFS volume. The function in the DAC security driver
> that chowns image files to the qemu user:group before using them
> already has special cases to ignore failure of chown on read-only file
> systems, and in a few other cases, but it hadn't been checking for
> EINVAL, which is what is returned if the qemu user doesn't even exist
> on the NFS server.

ACK.

> -        if (chown_errno == EOPNOTSUPP) {
> +        if (chown_errno == EOPNOTSUPP || chown_errno == EINVAL) {
>              VIR_INFO("Setting user and group to '%d:%d' on '%s' not supported by filesystem",

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]