[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] virsh: Add daemon version reporting



On 06/06/2011 06:17 AM, Daniel P. Berrange wrote:
>> +
>> +    ret = virConnectGetLibVersion(ctl->conn, &daemonVersion);
>> +    if (ret < 0) {
>> +        vshError(ctl, "%s", _("failed to get the daemon version"));
>> +        return false;
> 
> Raising an error here will prevent virsh talking to any
> libvirtd < 0.7.3

Also, this changes virsh output, which might break existing scripts.  It
would be safer to introduce a new bool flag, 'virsh version --daemon',
to specifically request the new output line.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]