[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 08/12] secret: drop dead code



Detected by Coverity.  The only ways to get to the cleanup label
were by an early abort (list still NULL) or after successfully
transferring list to dest, so there is no list to clean up.

* src/secret/secret_driver.c (loadSecrets): Kill dead code.
---
 src/secret/secret_driver.c |    8 +-------
 1 files changed, 1 insertions(+), 7 deletions(-)

diff --git a/src/secret/secret_driver.c b/src/secret/secret_driver.c
index 8f5e735..ee3c165 100644
--- a/src/secret/secret_driver.c
+++ b/src/secret/secret_driver.c
@@ -1,7 +1,7 @@
 /*
  * secret_driver.c: local driver for secret manipulation API
  *
- * Copyright (C) 2009-2010 Red Hat, Inc.
+ * Copyright (C) 2009-2011 Red Hat, Inc.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Lesser General Public
@@ -516,12 +516,6 @@ loadSecrets(virSecretDriverStatePtr driver,
     ret = 0;

 cleanup:
-    while (list != NULL) {
-        virSecretEntryPtr s;
-
-        s = listUnlink(&list);
-        secretFree(s);
-    }
     if (dir != NULL)
         closedir(dir);
     return ret;
-- 
1.7.4.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]