[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 10/12] build: silence coverity false positives



2011/6/6 Eric Blake <eblake redhat com>:
> Coverity complained about these intentional fallthrough cases, but
> not about other cases that were explicitly marked with nice comments.
>
> For some reason, Coverity doesn't seem smart enough to parse the
> up-front English comment in virsh about intentional fallthrough :)
>
> * tools/virsh.c (cmdVolSize): Mark fallthrough in a more typical
> fashion.
> * src/conf/nwfilter_conf.c (virNWFilterRuleDefDetailsFormat)
> (virNWFilterRuleDetailsParse): Mark explicit fallthrough.
> ---
>  src/conf/nwfilter_conf.c |    4 ++++
>  tools/virsh.c            |    3 +++
>  2 files changed, 7 insertions(+), 0 deletions(-)
>

ACK.

Matthias


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]