[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 09/12] esx: avoid dead code



On 06/07/2011 08:01 AM, Matthias Bolte wrote:
> 2011/6/6 Eric Blake <eblake redhat com>:
>> Detected by Coverity.  The beginning of the function already filtered
>> out NULL objectContentList as invalid; more likely, the code was
>> trying to see if esxVI_RetrieveProperties modified *objectContentList.
>>
>> * src/esx/esx_vi.c (esxVI_LookupObjectContentByType): Check
>> correct pointer.

> Your patch now fixes this and is also a potential
> segfault fix because callers of esxVI_LookupObjectContentByType that
> specified "required" occurrence assume *objectContentList to be
> non-NULL when esxVI_LookupObjectContentByType succeeds.

Thanks for the additional details; I summarized those into the commit
message.

> 
> ACK.

I've now pushed the entire series.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]