[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/16] apparmor: Convert virExec usage to virCommand



On Tue, 2011-05-10 at 17:32 -0600, Eric Blake wrote:
> On 05/10/2011 02:07 PM, Cole Robinson wrote:
> > Untested
> 
> Was it compile-tested, at least?
> 
> > 
> > Signed-off-by: Cole Robinson <crobinso redhat com>
> > ---
> >  src/security/security_apparmor.c |   70 +++++++-------------------------------
> >  1 files changed, 13 insertions(+), 57 deletions(-)
> 
> 1:4 ratio.  It looks okay to me by inspection, but I likewise haven't
> fired up a debian-based machine to test it.
> 
> ACK; we'll hear about it soon enough if it breaks anything, although
> that seems unlikely based on my read of it.

I finally got around to testing this. Applying this patch along with
Matthias Bolte from 05/13 onto 0.9.1 shows it to work just fine.

Belated ACK

-- 
Jamie Strandboge             | http://www.canonical.com

Attachment: signature.asc
Description: This is a digitally signed message part


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]