[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/4] vcpupin: introduce a new libvirt API (virDomainPinVcpuFlags)



On 06/13/2011 10:01 AM, Eric Blake wrote:
> On 06/13/2011 07:44 AM, Daniel Veillard wrote:
>>>  
>>>  /**
>>> + * virDomainPinVcpuFlags:
> 
>>> +
>>> +/**
>>>   * virDomainGetVcpus:
> 
> We need a virDomainGetVcpusFlags counterpart, so that we can query
> either the config or the live state.

That didn't come across quite as clear as I intended, so I'll try again
with more details:

Right now, the 'vcpupin' command in virsh uses only the
virDomainPinVcpu{,Flags} API to set the vcpu pinning, while the
'vcpuinfo' command queries the existing vcpu details, including pinning
details.  But 'vcpuinfo' currently fails on a non-running information,
and it uses the virDomainGetVcpus command; which means we need a
counterpart command (virDomainGetVcpusFlags) which will let us query the
persistent vcpu settings of an inactive domain.

Furthermore, it might be nice to add 'virsh vcpupin --query', which
prints the pinning information in the same manner of string as can be
used to set pinning, rather than the current 'virsh vcpuinfo' which is
rather complex for parsing.

So, I think we still need some more work on this front before 0.9.3 is
released.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]