[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [RFC PATCH] Set and reset MAC for PASSTHROUGH mode



On 06/10/2011 05:40 AM, Dirk Herrendoerfer wrote:
> there is a problem present in libvirt that when a PASSTHROUGH mode 
> DIRECT NIC connection is made the MAC address of the NIC is not 
> automatically set and reset to the configured VM MAC and back again.
> 
> The attached patch fixes this problem by setting and resetting the MAC
> while remembering the previous setting while the VM is running.
> This also works if libvirtd is restarted while the VM is running.
> 
> The storing of the previous MAC address is done in a link ( currently in /tmp,
> but should probably go into /var/run somewhere ).

/tmp is probably not the best place; we already have a hierarchy under
/var/run/libvirt/ and this information should live somewhere in that
hierarchy.

Meanwhile, this information is useful in the commit message itself,
rather than in a cover letter...

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]