[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] Use '-' to read from stdin



Changes made, will submit an updated patchset after finalizing the next
patch.

On 6/13/11 10:50 PM, Eric Blake wrote:
> Question: is this sufficient?  That is, do all virsh.c callers that read
> file contents eventually call into this function, or do you need to also
> hook up some other locations to honor "-"?
The virsh commands that I was looking at (create, define,
network-create, etc) called virFileReadAll when reading in the entire
file contents, and the other abstracted read functions use fd's rather
than a path.  By the time it expects an fd, it seemed that it was too
late to be checking for stdin.

--
~Michael Williams


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]