[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [libvirt-users] request to add an application the app listing on libvirt site



[adding libvir-list for patch tracking]

On 06/14/2011 10:17 AM, Ohad Levy wrote:
>> the simplest is to actually send a patch against the file docs/
>> apps.html.in
>> in the source tree. I would think "Ruby Objects for libvirt" should be
>> added in the "libraries" section, and "Foreman" in the "provisioning"
>> section. The pages are maintained in the source which also allow to
>> package them easilly, I hope making an HTML patch isn't too complex,
>> if not say so I will do it myself :-)
>>
>>  thanks !
>>
>> thanks! see attached patch.
> 

Thanks for the patch.

Your mailer sent both plain text and html renderings of the email body;
that is overkill (plain text alone works just fine).

> +    <dl>
> +      <dt><a href="http://theforeman.org";>Foreman</a></dt>
> +      <dd>
> +      Foreman is an open source web based application aimed to be a Single Address For All Machines Life Cycle Management, Foreman:
> +

That's a long line.  I reformatted to break things to 80 columns where
reasonably possible, and added your name to AUTHORS.  Let me know if you
prefer an alternate spelling there (for example, the commit was
attributed to your gmail.com address, although I see that you also have
a redhat.com address).  Also, I saw some grammar nits.

ACK and pushed as modified:

diff --git i/docs/apps.html.in w/docs/apps.html.in
index 69c9aaa..6b5afdb 100644
--- i/docs/apps.html.in
+++ w/docs/apps.html.in
@@ -15,7 +15,7 @@
       To add an application not listed on this page, send a message
       to the <a href="contact.html">mailing list</a>, requesting it
       be added here, or simply send a patch against the documentation
-      in our git docs sub directory.
+      in the libvirt.git docs subdirectory.
       If your application uses libvirt as its API,
       the following graphic is available for your website to advertise
       support for libvirt:
@@ -232,11 +232,11 @@
             <dt><a href="https://github.com/ohadlevy/virt#readme";>Ruby
             Libvirt Object bindings</a></dt>
             <dd>
-                Virt Allows using simple ruby objects to manipulate
+                Allows using simple ruby objects to manipulate
                 hypervisors, guests, storage, network etc.  It is
                 based on top of
                 the <a href="http://libvirt.org/ruby";>native ruby
-                binding</a>.
+                bindings</a>.
             </dd>
         </dl>
     <h2><a name="livecd">LiveCD / Appliances</a></h2>


-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]