[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 08/10 V2] send-key: Implementing the remote protocol



On 06/14/2011 03:32 AM, Matthias Bolte wrote:
>>>>> +/*
>>>>> + * Max number of sending keycodes.
>>>>> + */
>>>>> +const REMOTE_SEND_KEY_MAX = 16;
>>>>
>>>> Should call this  REMOTE_DOMAIN_SEND_KEY_MAX really
>>>>
>> Of course '16' is no where near kilobytes, so perhaps we can raise it
>> a little, but I don't think we should give application developers the
>> idea that this is useful for sending large data volumes.
>>
> Okay, I'm fine with that. But then we should also state this in the
> documentation of virDomainSendKey (patch 7/10) that this is only meant
> for a few key stokes at a time.

At any rate, 16 is consistent between this patch and MAX_SEND_KEY
(renamed VIR_DOMAIN_SEND_KEY_MAX_KEYS) of patch 05/10, and I'm okay
leaving it at 16 for now.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]