[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/12] [v7] virNodeGetCPUStats: Expose new API



On 06/14/2011 03:02 AM, Daniel P. Berrange wrote:
>> + * Macro for the total CPU time/utilization
>> + */
>> +#define VIR_CPU_STATS_ALL_CPUS -1

Should be (-1) for safety.

>>  
>> +LIBVIRT_0.9.3 {
>> +    global:
>> +        virNodeGetCPUStats;
>> +} LIBVIRT_0.9.2;

This needed (trivial) rebasing.

>> +
>>  # .... define new API here using predicted next version number ....
> 
> ACK

'make check' failed for me, on generating python bindings:

/usr/bin/python ./generator.py /usr/bin/python
Found 289 functions in libvirt-api.xml
Found 1 functions in libvirt-override-api.xml
Generated 252 wrapper functions
Missing type converters:
virCPUStatsPtr:1
ERROR: failed virNodeGetCPUStats

Pushed with this squashed in:

diff --git i/include/libvirt/libvirt.h.in w/include/libvirt/libvirt.h.in
index 0f2b4e8..4bd2cdc 100644
--- i/include/libvirt/libvirt.h.in
+++ w/include/libvirt/libvirt.h.in
@@ -313,7 +313,7 @@ struct _virNodeInfo {
  *
  * Macro for the total CPU time/utilization
  */
-#define VIR_CPU_STATS_ALL_CPUS -1
+#define VIR_CPU_STATS_ALL_CPUS (-1)

 /**
  * VIR_CPU_STATS_KERNEL:
diff --git i/python/generator.py w/python/generator.py
index 634b788..d929efa 100755
--- i/python/generator.py
+++ w/python/generator.py
@@ -363,6 +363,7 @@ skip_impl = (
     'virConnectBaselineCPU',
     'virDomainRevertToSnapshot',
     'virDomainSendKey',
+    'virNodeGetCPUStats',
 )


-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]