[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 7/8] Asynchronous event for BlockPull completion

On 06/14/2011 08:36 AM, Adam Litke wrote:
> When an operation started by virDomainBlockPullAll completes (either with
> success or with failure), raise an event to indicate the final status.  This
> allows an API user to avoid polling on virDomainBlockPullInfo if they would
> prefer to use the event mechanism.
> * daemon/remote.c: Dispatch events to client
> * include/libvirt/libvirt.h.in: Define event ID and callback signature
> * src/conf/domain_event.c, src/conf/domain_event.h,
>   src/libvirt_private.syms: Extend API to handle the new event
> * src/qemu/qemu_driver.c: Connect to the QEMU monitor event
>   for block_stream completion and emit a libvirt block pull event
> * src/remote/remote_driver.c: Receive and dispatch events to application
> * src/remote/remote_protocol.x: Wire protocol definition for the event
> * src/qemu/qemu_monitor.c, src/qemu/qemu_monitor.h,
>   src/qemu/qemu_monitor_json.c: Watch for BLOCK_STREAM_COMPLETED event
>   from QEMU monitor
> Signed-off-by: Adam Litke <agl us ibm com>

ACK for fixing the issues raised in v3.  There was a slight merge
conflict, but not serious.

I'm not pushing 8/8 (it really does belong more in libvirt-tck, once the
perl bindings catch up), so I think this series is now complete, other
than my ideas for enhancing virsh blockpull --all to take a --block flag
that waits for the event.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]