[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: Translate boot config into bootindex if possible



On Tue, Jun 14, 2011 at 14:13:59 -0600, Eric Blake wrote:
> On 06/06/2011 07:32 AM, Jiri Denemark wrote:
> > Prefer bootindex=N option for -device over the old way -boot ORDER
> > possibly accompanied with boot=on option for -drive. This gives us full
> > control over which device will actually be used for booting guest OS.
> > Moreover, if qemu doesn't support boot=on, this is the only way to boot
> > of certain disks in some configurations (such as virtio disks when used
> > together IDE disks) without transforming domain XML to use per device
> > boot elements.
> > ---
> >  src/qemu/qemu_command.c                            |  141 +++++++++++++-------
> >  src/qemu/qemu_command.h                            |    4 +-
> >  src/qemu/qemu_hotplug.c                            |   14 +-
> >  .../qemuxml2argv-boot-complex-bootindex.args       |   30 ++++
> >  .../qemuxml2argv-boot-complex-bootindex.xml        |   65 +++++++++
> >  .../qemuxml2argv-boot-complex.args                 |   30 ++++
> >  .../qemuxml2argvdata/qemuxml2argv-boot-complex.xml |   65 +++++++++
> >  ...xml2argv-boot-menu-disable-drive-bootindex.args |   13 ++
> >  ...uxml2argv-boot-menu-disable-drive-bootindex.xml |   27 ++++
> >  .../qemuxml2argv-boot-menu-disable-drive.args      |   14 ++
> >  .../qemuxml2argv-boot-menu-disable-drive.xml       |   27 ++++
> >  .../qemuxml2argv-boot-menu-enable.args             |   14 ++
> >  .../qemuxml2argv-boot-menu-enable.xml              |   27 ++++
> >  .../qemuxml2argv-disk-drive-no-boot.args           |   18 +++
> >  .../qemuxml2argv-disk-drive-no-boot.xml            |   38 ++++++
> >  tests/qemuxml2argvtest.c                           |   17 +++
> >  16 files changed, 489 insertions(+), 55 deletions(-)
> 
> Big patch, but the majority is testsuite coverage, so that makes me feel
> better.  Lots to read, but I didn't spot anything obviously wrong, and
> the tests passed when I applied this.
> 
> ACK.

Pushed, thanks.

Jirka


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]