[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] support for Xen HVM Viridian (Hyper-V) enlightenment interface



On 06/15/2011 07:27 AM, Daniel Gollub wrote:
> Introduce libvirt support for Xen HVM Viridian (Hyper-V) enlightenment
> interface guest feature.
> 
> 
> ---
>  src/conf/domain_conf.c     |    3 ++-
>  src/conf/domain_conf.h     |    1 +
>  src/xen/xen_hypervisor.c   |   11 +++++++++++
>  src/xenapi/xenapi_driver.c |    2 ++
>  src/xenapi/xenapi_utils.c  |    2 ++
>  src/xenxs/xen_sxpr.c       |    4 ++++
>  src/xenxs/xen_xm.c         |   12 +++++++++++-
>  7 files changed, 33 insertions(+), 2 deletions(-)

Thanks; this looks straightforward.  However, your mailer corrupted the
patch (by using quoted-printable in a way that git couldn't undo), so it
didn't apply easily.

> 
> diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c
> index 0d9fef4..a90f676 100644
> --- a/src/conf/domain_conf.c
> +++ b/src/conf/domain_conf.c
> @@ -84,7 +84,8 @@ VIR_ENUM_IMPL(virDomainFeature, VIR_DOMAIN_FEATURE_LAST,
>                "acpi",
>                "apic",
>                "pae",
> -              "hap")
> +              "hap",
> +	      "viridian")

TAB character.  'make syntax-check' calls you on this and 2 other spots.

ACK with that fixed, so I've pushed it.  Also, I added you to AUTHORS,
let me know if I need to adjust spelling of your name or preferred email.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]