[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2]: set and restore MAC address of a NIC when using PASSTHROUGH mode



On Thu, 2011-06-16 at 19:16 +0100, Daniel P. Berrange wrote:
> There are already (static) functions in src/util/bridge.c, which are
> able to get and set the MAC address on network devices. So I think we
> should just make them non-static and call them instead of duplicating
> it here. 

I just sent out another version of the patch addressing all remarks
except this last one. I had some difficulties with this and there is
also only a function to set the MAC address. I will have another look
into this next week, but would appreciate some feedback on the other
changes in the meantime.

-- 
Best regards, 

Gerhard Stenzel, 
-----------------------------------------------------------------------------------------------------------------------------------
IBM Deutschland Research & Development GmbH
Vorsitzender des Aufsichtsrats: Martin Jetter
Geschäftsführung: Dirk Wittkopp
Sitz der Gesellschaft: Böblingen
Registergericht: Amtsgericht Stuttgart, HRB 243294


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]