[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 02/10] python: generator: Don't print warning if nothing to warn about



On 06/16/2011 09:44 AM, Daniel Veillard wrote:
> On Wed, Jun 15, 2011 at 09:23:11PM -0400, Cole Robinson wrote:
>>
>> Signed-off-by: Cole Robinson <crobinso redhat com>
>> ---
>>  python/generator.py |    8 +++++---
>>  1 files changed, 5 insertions(+), 3 deletions(-)
>>
>> diff --git a/python/generator.py b/python/generator.py
>> index 39c3ca7..6ee0ada 100755
>> --- a/python/generator.py
>> +++ b/python/generator.py
>> @@ -654,9 +654,11 @@ def buildStubs():
>>  
>>      print "Generated %d wrapper functions" % nb_wrap
>>  
>> -    print "Missing type converters: "
>> -    for type in unknown_types.keys():
>> -        print "%s:%d " % (type, len(unknown_types[type])),
>> +    if unknown_types:
>> +        print "Missing type converters: "
>> +        for type in unknown_types.keys():
>> +            print "%s:%d " % (type, len(unknown_types[type])),
>> +
>>      print
> 
>   ACK, man, that's old code :-)
> 

:) Thanks, pushed now.

- Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]