[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] cleanup: make nlComm commonly available



On Tue, Jun 21, 2011 at 02:32:29PM -0600, Eric Blake wrote:
> On 06/21/2011 10:08 AM, Stefan Berger wrote:
> > In a first cleanup step, make nlComm from macvtap.c commonly available
> > for other code to use. Since nlComm uses Linux-specific structures as
> > parameters it's prototype is only visible on Linux.
> > 
> > Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>
> > 
> > ---
> >  src/Makefile.am          |    1
> >  src/libvirt_private.syms |    4 +
> 
> The code motion looks okay to me.  However:
> 
> Exporting the private symbols says the symbols must be available
> everywhere...

Or you could add the symbols to src/libvirt_linux.syms instead

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]