[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 2/2 V2] cleanup: make several interface functions commonly available

On 06/21/2011 06:05 PM, Stefan Berger wrote:
> In a second cleanup step this patch makes several interface functions
> from macvtap.c commonly available by moving them into interface.c and
> prefixing their names with 'iface'. 
> ifaceRestoreMacAddress returns the return code from the
> ifaceSetMacAddres call and display an error message if setting the MAC
> address did not work. The caller is unchanged and still ignores the
> return code (which is ok).
> This patch also fixes a problem with the return code of
> ifaceSetMacAddress being used for error reporting in one place rather
> than errno.
> v2:
>  - making all functions visible on all platforms
> Signed-off-by: Stefan Berger <stefanb linux vnet ibm com>

ACK.  The libvirt_linux.syms suggestion was nice too, but now that
you've already done the work to expose the symbols everywhere, it
doesn't hurt to keep it that way.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]