[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/3] Add Processor/MemoryDevice information to virSysinfoRead() API



Hi, Daniel

Thank you for you reply.

On Thu, 23 Jun 2011 09:36:11 +0800
Daniel Veillard <veillard redhat com> wrote:

> On Tue, Jun 21, 2011 at 01:17:38PM +0900, Minoru Usui wrote:
> > Hi,
> > 
> > I propose to add hardware Processor/MemoryDevice information to virSysinfoRead() from SMBIOS.
> > I want to get host machine's these infomations through virConnectGetSysinfo().
> > 
> > I think it's useful to managing many host machines,
> > because administrator can centrally manage the host machines which consists of
> > Processor/MemoryDevice parts. 
> > 
> > This patch set adds DMI type4, 17 information(dmidecode -t4,17) to virSysinfoRead().
> > I hope this patch set adds v0.9.3, if possible.
> 
>  it's a bit late. What is the expected output ? You should have added
> that for easier review,

I'm sorry for late posting and lack explanation.
Expected output is below.

I add "<processor>" and "<memory_device>" part.
"<processor>" part gets "Processor Information" part of dmidecode -t4,
and "<memory_device>" part gets existing "Memory Device" part of dmidecode -t17.
Existing "Memory Device" part means "Size" member is not "No Module Installed". 

How about this?

-------------------------------------------------------------
# ./build/tools/virsh sysinfo
<sysinfo type='smbios'>
  <bios>
    <entry name='vendor'>Phoenix Technologies LTD</entry>
    <entry name='version'>1.0.5S46</entry>
    <entry name='date'>12/21/2006</entry>
  </bios>
  <system>
    <entry name='manufacturer'>NEC</entry>
    <entry name='product'>Express5800/120Rg-1 [N8100-1241]</entry>
    <entry name='version'>FR1.5</entry>
    <entry name='serial'>6800109</entry>
    <entry name='uuid'>BC466200-2232-11DB-8001-001617617E41</entry>
    <entry name='sku'>Not Specified</entry>
    <entry name='family'>Not Specified</entry>
  </system>
  <processor>
    <entry name='socket_destination'>CPU#1     </entry>
    <entry name='type'>Central Processor</entry>
    <entry name='family'>Xeon</entry>
    <entry name='manufacturer'>Intel Corporation</entry>
    <entry name='signature'>Type 0, Family 6, Model 15, Stepping 7</entry>
    <entry name='version'>Intel(R) Xeon(R) CPU           E5345  @ 2.33GHz                 </entry>
    <entry name='external_clock'>333 MHz</entry>
    <entry name='max_speed'>3000 MHz</entry>
    <entry name='status'>Populated, Enabled</entry>
    <entry name='serial_number'> </entry>
    <entry name='part_number'> </entry>
  </processor>
  <processor>
    <entry name='socket_destination'>CPU#2     </entry>
    <entry name='type'>Central Processor</entry>
    <entry name='family'>Xeon</entry>
    <entry name='manufacturer'>Intel Corporation</entry>
    <entry name='signature'>Type 0, Family 6, Model 15, Stepping 7</entry>
    <entry name='version'>Intel(R) Xeon(R) CPU           E5345  @ 2.33GHz                 </entry>
    <entry name='external_clock'>333 MHz</entry>
    <entry name='max_speed'>3000 MHz</entry>
    <entry name='status'>Populated, Enabled</entry>
    <entry name='serial_number'> </entry>
    <entry name='part_number'> </entry>
  </processor>

         :  continue number of "Processor Information" of dmidecode  times

  <memory_device>
    <entry name='size'>1024 MB</entry>
    <entry name='form_factor'>DIMM</entry>
    <entry name='locator'>DIMM 11</entry>
    <entry name='bank_locator'>BANK 1</entry>
    <entry name='type'>DDR2</entry>
    <entry name='type_detail'>Synchronous</entry>
    <entry name='speed'>533 MHz</entry>
    <entry name='manufacturer'>80CE   </entry>
    <entry name='serial_number'>030C5822</entry>
    <entry name='part_number'>M395T2953CZ4-CE61 </entry>
  </memory_device>
  <memory_device>
    <entry name='size'>1024 MB</entry>
    <entry name='form_factor'>DIMM</entry>
    <entry name='locator'>DIMM 21</entry>
    <entry name='bank_locator'>BANK 1</entry>
    <entry name='type'>DDR2</entry>
    <entry name='type_detail'>Synchronous</entry>
    <entry name='speed'>533 MHz</entry>
    <entry name='manufacturer'>80CE   </entry>
    <entry name='serial_number'>030C5638</entry>
    <entry name='part_number'>M395T2953CZ4-CE61 </entry>
  </memory_device>

         :  continue number of existing "Memory Device" times
</sysinfo>
-------------------------------------------------------------

> Daniel
> 
> -- 
> Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
> daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
> http://veillard.com/ | virtualization library  http://libvirt.org/


-- 
Minoru Usui <usui mxm nes nec co jp>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]