[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v5 0/5] Add TXT record and hosts support for DNS service and dnsmasq command-line regression testing



On 06/14/2011 09:02 AM, Michal Novotny wrote:
this is the patch to introduce the TXT record and DNS hosts support
for the DNS service on the virtual network.

This series is very close, and I'd like to see it go in in time for this release (keep in mind that the freeze for new features is sometime between Friday and Monday).

There are only two issues left that I haven't provided diffs to fix:

1) Once Patch 2/5 is applied, make check fails. This is solved in Patch 3/5, but we really need each patch to pass make check, otherwise the utility of git bisect is compromised. To fix this, the changes to bridge_driver.c in 2/5 and 3/5 need to be combined into a new 2/5, and the other changes from those two patches (everything associated with the regression tests) needs to be combined into the new 3/5.

2) The data structure for virNetworkDNSHostsDef is not a correct model of the data, leading to unnecessarily complicated code. Rather than being:

  struct virNetworkDNSHostsDef {
      virSocketAddr ip;
      char *name;
  } virNetworkDNSHostsDef;

  struct virNetworkDNSHostsDef {
      virSocketAddr ip;
      unsigned int nnames;
      char **names;
  } virNetworkDNSHostsDef;

names will be an array of names, rather than a single name. This will eliminate all of the strange loops in virNetworkDNSHostsDefParseXML, and make the created hosts file a more accurate image of what is defined in the XML.

Once those two items are fixed, we can push this.

Thanks for being so patient!


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]