[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix compilation on non-macvtap systems



2011/6/23 Laine Stump <laine laine org>:
> On 06/22/2011 06:42 PM, Matthias Bolte wrote:
>>
>> The refactoring in 6a5978833a5 and df3d8c362d3 was incomplete
>> as it accidentally moved macvtap related code out of a
>> #if WITH_MACVTAP in a #if __linux__ block. To fix this move
>> ifaceMacvtapLinkAdd and ifaceMacvtapLinkDump back under
>> #if WITH_MACVTAP.
>>
>> Also nlComm was moved from #if WITH_MACVTAP to #if __linux__
>> but configure.ac was not updated to match this, as libnl is
>> now required on Linux always because of this.
>
> So with your changes it's still required for all Linux builds? That's
> potentially not good at all. RHEL5 uses libnl 1.0, which is not ABI
> compatible with libnl 1.1 (which everything in libvirt is written to). (Up
> to now we've been saved the headache because macvtap isn't enabled/supported
> on RHEL5.)

Well, the whole problem was introduced by Stefans cleanup commits. Is
there some higher level reason for this refactoring? There probably
is, but If not then the simplest fix is to revert the offending
commits.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]