[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] util: Fix memory leak in virJSONParserHandleStartMap



On Thu, Jun 23, 2011 at 03:55:38PM +0800, Osier Yang wrote:
> ---
>  src/util/json.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/src/util/json.c b/src/util/json.c
> index db2727d..48521f2 100644
> --- a/src/util/json.c
> +++ b/src/util/json.c
> @@ -799,8 +799,10 @@ static int virJSONParserHandleStartMap(void *ctx)
>      }
>  
>      if (VIR_REALLOC_N(parser->state,
> -                      parser->nstate + 1) < 0)
> +                      parser->nstate + 1) < 0) {
> +        virJSONValueFree(value);
>          return 0;
> +    }
>  
>      parser->state[parser->nstate].value = value;
>      parser->state[parser->nstate].key = NULL;

 ACK,

Daniel

-- 
Daniel Veillard      | libxml Gnome XML XSLT toolkit  http://xmlsoft.org/
daniel veillard com  | Rpmfind RPM search engine http://rpmfind.net/
http://veillard.com/ | virtualization library  http://libvirt.org/


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]