[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 01/10] Defines the basics of a generic RPC protocol in XDR



On 06/23/2011 03:49 PM, Eric Blake wrote:
>>
>> * src/Makefile.am: Add rules for generating RPC code from
>>   protocol & define a new libvirt-net-rpc.la helper library
>> * src/rpc/virnetprotocol.x: New generic RPC protocol
>> * src/rpc/virnetprotocol.c, src/rpc/virnetprotocol.h: Generated
>>   from virnetprotocol.x
> 
> Now that generated files are not kept in git, do you need to mention
> them in this commit message?  I guess it doesn't hurt, though.
> 
>> ---
>>  src/Makefile.am          |   19 +++-
>>  src/rpc/virnetprotocol.x |  217 ++++++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 232 insertions(+), 4 deletions(-)
>>  create mode 100644 src/rpc/virnetprotocol.x

Also, squash this in:

diff --git i/.gitignore w/.gitignore
index a4d3ea1..0628732 100644
--- i/.gitignore
+++ w/.gitignore
@@ -53,6 +53,7 @@
 /src/libvirt_iohelper
 /src/remote/*_client_bodies.h
 /src/remote/*_protocol.[ch]
+/src/rpc/virnetprotocol.[ch]
 /tests/*.log
 /tests/cputest
 /tests/hashtest


-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]