[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH] build: avoid python 2.4 build failure



On RHEL 5, I got:

/usr/bin/python ./generator.py /usr/bin/python
  File "./generator.py", line 427
    "virStreamFree", # Needed in custom virStream __del__, but free shouldn't
                   ^
SyntaxError: invalid syntax

* python/generator.py (function_skip_python_impl): Use same syntax
as other skip lists.
---

Pushing under the build-breaker rule.  However, the build is still
broken on RHEL 5, due to this next one that I don't know how to fix
(probably we'll have to test in configure.ac whether Py_ssize_t
exists, and if not, typedef it ourself in libvirt-override.c):

In file included from libvirt-override.c:22:
typewrappers.h:159: error: expected declaration specifiers or '...' before 'Py_ssize_t'

 python/generator.py |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/python/generator.py b/python/generator.py
index a3ebcf9..6ce6596 100755
--- a/python/generator.py
+++ b/python/generator.py
@@ -423,10 +423,10 @@ skip_function = (
 )

 # Generate C code, but skip python impl
-function_skip_python_impl = {
+function_skip_python_impl = (
     "virStreamFree", # Needed in custom virStream __del__, but free shouldn't
                      # be exposed in bindings
-}
+)

 function_skip_index_one = (
     "virDomainRevertToSnapshot",
-- 
1.7.4.4


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]