[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 05/10] Generic module for handling SASL authentication & encryption



On Thu, Jun 23, 2011 at 05:13:12PM -0600, Eric Blake wrote:
> On 06/22/2011 09:33 AM, Daniel P. Berrange wrote:
> > This provides two modules for handling SASL
> > 
> >  * virNetSASLContext provides the process-wide state, currently
> >    just a whitelist of usernames on the server and a one time
> >    library init call
> > 
> >  * virNetTLSSession provides the per-connection state, ie the
> >    SASL session itself. This also include APIs for providing
> >    data encryption/decryption once the session is established
> > 
> > * src/Makefile.am: Add to libvirt-net-rpc.la
> > * src/rpc/virnetsaslcontext.c, src/rpc/virnetsaslcontext.h: Generic
> >   SASL handling code
> > ---
> >  cfg.mk                      |    2 +
> >  po/POTFILES.in              |    1 +
> >  src/Makefile.am             |    9 +
> >  src/rpc/virnetsaslcontext.c |  598 +++++++++++++++++++++++++++++++++++++++++++
> >  src/rpc/virnetsaslcontext.h |  120 +++++++++
> >  5 files changed, 730 insertions(+), 0 deletions(-)
> >  create mode 100644 src/rpc/virnetsaslcontext.c
> >  create mode 100644 src/rpc/virnetsaslcontext.h
> > 
> > --- /dev/null
> > +++ b/src/rpc/virnetsaslcontext.h
> > @@ -0,0 +1,120 @@
> 
> > +#ifndef __VIR_NET_CLIENT_SASL_CONTEXT_H__
> > +# define __VIR_NET_CLIENT_SASL_CONTEXT_H__
> > +
> > +# include <sasl/sasl.h>
> > +
> > +# include <stdbool.h>
> > +# include <sys/types.h>
> 
> Are these two still needed?  Or can we expect that all .c clients have
> already picked them up from internal headers prior to including this header?

No, I can replace them with 'internal.h'

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]