[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Improve IPv6 detection for virNetSocket tests



2011/6/24 Eric Blake <eblake redhat com>:
> On 06/24/2011 09:39 AM, Matthias Bolte wrote:
>> getifaddrs can return an IPv6 address, but getaddrinfo can fail
>> for an IPv6 address. Cover this combination.
>> ---
>>
>> This is only tested on my system with broken IPv6. Could someone test this
>> on an IPv6 capable system and ensure that the IPv6 tests aren't skipped now
>> by running
>>
>>   cd tests
>>   make virnetsockettest
>>   PATH=`pwd`:$PATH LIBVIRT_DEBUG=1 ./virnetsockettest
>>
>> This should print something like this
>>
>>   17:35:09.810: 4102: debug : checkProtocols:83 : Protocols: v4 1 v6 1
>>
>> on an IPv6 capable system.
>
> Done, and worked for me.
>
> ACK to the patch.
>

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]