[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v6 2/5] Network: Add regression tests for the command-line arguments

On 06/24/2011 06:04 AM, Michal Novotny wrote:
The regression testing done by comparison of command-line
generated from the network XML file and the expected
command-line arguments (read from file).

Differences between v5 and v6 (this one:
  - For the tests the pidfile is set to NULL string so there's
    no --pidfile argument passed to the dnsmasq.

ACK (with modification detailed below) and pushed.

I combined this patch with Patch 3/5. then split that into a new patch 2/5 that contains just the bridge_driver.[ch] changes (and libvirt_network.syms), and a new 3/5 that contains just the new tests. I verified that the end result after applying both patches was identical to yours, and pushed.

Note that the test does still generate an error message if you've turned VIR_TEST_DEBUG on - it is trying to write the hosts file to /var/lib/libvirt/dnsmasq and failing. However, the test still succeeds when this happens, so although it's something we should fix, it shouldn't keep it from going in.

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]