[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/5] vcpuinfo: add the code to fallback to try new API



On 06/24/2011 03:01 AM, Taku Izumi wrote:
> 
> The "virsh vcpuinfo" command results in failure when the target domain
> is inactive on KVM. This patch improves this behavior by adding the
> fallback to invoke virDomainGetVcpupinInfo API in case of 
> virDomainGetVcpus API returns error and the target domain is inactive.
> 
> 
> Signd-off-by: Taku Izumi <izumi taku jp fujitsu com>

s/Signd/Signed/

[unlike the kernel folks, we aren't sticklers about S-O-B lines on this
list, but if you use it, you might as well use it correctly ;)]

ACK as-is!

> +        if (info.state == VIR_DOMAIN_SHUTOFF &&
> +            (ncpus = virDomainGetVcpupinInfo(dom, info.nrVirtCpu,

Well, there's the s/Vcpupin/VcpuPin/ change coming up later, but it has
wider-reaching effects, so I'll leave it separate.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]