[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] tests: Handle networkxml2argvtest being configure --localstatedir dependant

On 06/25/2011 06:41 AM, Matthias Bolte wrote:
> networkxml2argvtest indirectly calls networkDnsmasqLeaseFileName
> that depends on configure --localstatedir. Therefore, the .argv
> files used in the test have to be created with this localstatedir.
> Move the .argv to .argv.in files with a @localstatedir@ placeholder.

Will this work in VPATH builds?  Previously, we have done hacks where
the test directory can provide an override string; if the override is
NULL (the default, for use in libvirtd), then use @localstatedir@, but
if the override is provided (from the test case), then use that instead.
 That is, by changing networkDnsmasqLeaseFileName to honor an override,
we can avoid having to use all these .argv.in test files, and avoid
having to worry about VPATH builds generating the .argv in a different
location than the .argv.in files.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]