[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2] tests: Partly fix networkxml2argvtest being configure result dependent



2011/6/27 Eric Blake <eblake redhat com>:
> On 06/27/2011 09:08 AM, Matthias Bolte wrote:
>> Convert networkDnsmasqLeaseFileName to a replaceable function pointer
>> that allow the testsuite to use a version of that function that is not
>> depending on configure --localstatedir.
>>
>> This fixes 5 of 6 test failures, when configure --localstatedir isn't
>> set to /var.
>> ---
>>
>> The last failure is related to networkBuildDhcpDaemonCommandLine
>> trying to indirectly write dnsmasq config files to disk. This needs
>> a larger rewrite to separate the config file writing out of
>> networkBuildDhcpDaemonCommandLine.
>
> Incremental progress is better than none, so:
>
> ACK.
>

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]