[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test



On 06/27/2011 09:11 AM, Laine Stump wrote:
> On 06/27/2011 07:30 AM, Matthias Bolte wrote:
>> 2011/6/27 Zdenek Styblik<stybla turnovfree net>:
>>> Reporting Slackware64-13.37:

>>> /usr/include/netlink/object.h:58:23: warning: inline function
>>> 'nl_object_priv' declared but never defined
>>> /usr/include/netlink/object.h:58:23: warning: inline function
>>> 'nl_object_priv' declared but never defined
>>> ~~~ SNIP ~~~
>> This is a known problem in libnl. This can be fixed in Slackware's
>> libnl package by removing the inline keyword from the declaration of
>> nl_object_priv in /usr/include/netlink/object.
> 
> What is the version of libnl used in Slackware? It seems that libnl is
> getting included on more platforms now, so we probably need to get more
> serious about making sure our code works with different versions of libnl.

If it is anything like Ubuntu, then this (hacky) patch will work around
the problem in spite of the broken libnl headers.  It's just that I'm
reluctant to apply it because it is such a hack, but given the number of
distros with broken libnl installations, maybe we should do it after all.

From ec12ae6be618f77542e30017eb80cffadd95e4f2 Mon Sep 17 00:00:00 2001
From: Eric Blake <eblake redhat com>
Date: Thu, 23 Jun 2011 16:30:15 -0600
Subject: [PATCH] work around libnl bug

---
 src/util/netlink.h |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/src/util/netlink.h b/src/util/netlink.h
index 6e915ff..de0e98b 100644
--- a/src/util/netlink.h
+++ b/src/util/netlink.h
@@ -24,7 +24,9 @@

 # if defined(__linux__) && defined(HAVE_LIBNL)

+#  define inline
 #  include <netlink/msg.h>
+#  undef inline

 # else

-- 
1.7.4.4



-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]