[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/4] Cleanup remote protocol definitions

On 06/27/2011 08:24 AM, Daniel P. Berrange wrote:
> The standard remote protocol for libvirtd no longer needs to
> include definitions of the generic message header/error structs
> or status codes. This is all defined in the generic RPC protocol
> * src/remote/remote_protocol.x: Remove all RPC message definitions
> * src/remote/remote_protocol.h, src/remote/remote_protocol.c:
>   Re-generate
> * daemon/remote_generate_stubs.pl: Delete obsolete script

Commit message is out-of-date; this file was renamed
daemon/remote_generator.pl in commit 999f5b3, then moved to
src/rpc/gendispatch.pl in commit b17b4af.

> ---
>  src/remote/remote_protocol.x |  115 ------------------------------------------
>  1 files changed, 0 insertions(+), 115 deletions(-)

Given the above commit message, should you also be trimming away at
src/rpc/gendispatch.pl, or any of the Makefile.am snippets that still
create the various *_bodies.h files?

ACK with that question resolved, and this squashed in.

diff --git i/src/remote_protocol-structs w/src/remote_protocol-structs
index c07ba81..25979b4 100644
--- i/src/remote_protocol-structs
+++ w/src/remote_protocol-structs
@@ -1615,11 +1615,3 @@ struct remote_domain_get_control_info_ret {
         u_int                      details;
         uint64_t                   stateTime;
-struct remote_message_header {
-        u_int                      prog;
-        u_int                      vers;
-        int                        proc;
-        remote_message_type        type;
-        u_int                      serial;
-        remote_message_status      status;

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]