[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] libvirt-0.9.3 week freeze, RC1 version to test



2011/6/28 simon jin <simonjin linux vnet ibm com>:
> 于 2011-6-28 16:20, Matthias Bolte 写道:
>
> 2011/6/28 simon jin <simonjin linux vnet ibm com>:
>
> 于 2011-6-27 23:17, Laine Stump 写道:
>
> On 06/27/2011 07:32 AM, Matthias Bolte wrote:
>
> 2011/6/27 simon<simonjin linux vnet ibm com>:
>
> 于 2011-6-27 13:01, Daniel Veillard 写道:
>
>    So we are entering the week freeze for the new version 0.9.3
> I have made an rc1 tarball available at:
>     ftp://libvirt.org/libvirt/libvirt-0.9.3-rc1.tar.gz
> along with rpms for those interested
> We pushed a lot of patches in the last few days, we know there is at
> least some cleanup issues, but I tried it locally and basic operations
> seems to work fine,
>
>    please give it a try too and report issues,
>
>     thanks !
>
> Daniel
>
> On fc14.x86_64
> TEST: networkxml2argvtest  FAIL
>
> Download  libvirt-0.9.3-rc1.tar.gz
>
> ./configure&&  make&&  make check
>
> It report 1 of 52 tests failed
>
> TEST: networkxml2argvtest
>        !.!!!!!                                  7   FAIL
> FAIL: networkxml2argvtest
>
> This a known problem when you configure libvirt with localstatedir
> other than /var, what happens when you just run configure without
> arguments.
>
> It looks like that's what he did, so maybe this is a different problem (or
> possibly his configure defaults to /usr/local/var?).
>
> If the default localstatedir isn't /var, try doing "./autogen.sh --system"
> instead of ./configure. If that doesn't cure the problem, try running the
> test with debug logging turned on to see exactly what error is reported:
>
>   LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
>
> I didn't use any arguments in configure, but the defaults localstatdir is
> /usr/local/var.
> I found below lines in config.status:
> S["prefix"]="/usr/local"
> S["localstatedir"]="${prefix}/var"
>
> ./autogen.sh --system will fix this issue.
>
> [libvirt-0.9.3]$  LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2
> tests/networkxml2argvtest
> TEST: tests/networkxml2argvtest
>  1) Network XML-2-Argv isolated-network                               ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/isolated-network.xml:
> failed to open: No such file or directory
> FAILED
>  2) Network XML-2-Argv routed-network                                 ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/routed-network.xml:
> failed to open: No such file or directory
> FAILED
>  3) Network XML-2-Argv nat-network                                    ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network.xml:
> failed to open: No such file or directory
> FAILED
>  4) Network XML-2-Argv netboot-network                                ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-network.xml:
> failed to open: No such file or directory
> FAILED
>  5) Network XML-2-Argv netboot-proxy-network                          ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/netboot-proxy-network.xml:
> failed to open: No such file or directory
> FAILED
>  6) Network XML-2-Argv nat-network-dns-txt-record                     ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-txt-record.xml:
> failed to open: No such file or directory
> FAILED
>  7) Network XML-2-Argv nat-network-dns-hosts                          ...
> /home/simon/Downloads/libvirt-0.9.3/networkxml2argvdata/nat-network-dns-hosts.xml:
> failed to open: No such file or directory
> FAILED
>
> Those .xml files actully under test/.
>
> -Simon Jin
>
> That's expected because you need to be in the tests directory to run a
> test manually or set the srcdir envvar to point to the test directory
>
> You ran
>
> LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 tests/networkxml2argvtest
>
> but Laine suggested
>
> LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2 ./networkxml2argvtest
>
> and missed to explicitly state that you need to cd to the tests directory
> first.
>
> cd test and run:
> [tests]$ sudo LIBVIRT_LOG_OUTPUTS=3:stderr VIR_TEST_DEBUG=2
> ./networkxml2argvtest
> [sudo] password for simon:
> TEST: networkxml2argvtest
>  1) Network XML-2-Argv isolated-network                               ...
> Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file=
> --except-interface lo --dhcp-option=3 --listen-address 192.168.152.1
> --dhcp-range 192.168.152.2,192.168.152.254
> --dhcp-leasefile=/var/lib/libvirt/dnsmasq/private.leases
> --dhcp-lease-max=253 --dhcp-no-override]
> Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file=
> --except-interface lo --dhcp-option=3 --listen-address 192.168.152.1
> --dhcp-range 192.168.152.2,192.168.152.254
> --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/private.leases
> --dhcp-lease-max=253 --dhcp-no-override]
>                                                                       ...
> FAILED
>
> Yes, the root cause is --localstatdir isn't set to /var. i see you have
> fixed it in trunk. Thanks
> -Simon Jin

Yep, that fixed 5 of 6 test failures.

>  2) Network XML-2-Argv routed-network                                 ... OK
>  3) Network XML-2-Argv nat-network                                    ...
> 16:31:38.713: 5636: info : libvirt version: 0.9.3
> 16:31:38.713: 5636: error : hostsfileSave:446 : cannot write config file
> '/usr/local/var/lib/libvirt/dnsmasq/default.hostsfile': Unknown error
> 18446744073709551614
>
> Expect [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file=
> --except-interface lo --listen-address 192.168.122.1 --listen-address
> 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address
> 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range
> 192.168.122.2,192.168.122.254
> --dhcp-leasefile=/var/lib/libvirt/dnsmasq/default.leases
> --dhcp-lease-max=253 --dhcp-no-override]
> Actual [/usr/sbin/dnsmasq --strict-order --bind-interfaces --conf-file=
> --except-interface lo --listen-address 192.168.122.1 --listen-address
> 192.168.123.1 --listen-address 2001:db8:ac10:fe01::1 --listen-address
> 2001:db8:ac10:fd01::1 --listen-address 10.24.10.1 --dhcp-range
> 192.168.122.2,192.168.122.254
> --dhcp-leasefile=/usr/local/var/lib/libvirt/dnsmasq/default.leases
> --dhcp-lease-max=253 --dhcp-no-override]
>                                                                       ...
> libvir: Network Config error : cannot write config file
> '/usr/local/var/lib/libvirt/dnsmasq/default.hostsfile': Unknown error
> 18446744073709551614
> FAILED

The tested code tries to write files to disk, it shouldn't do that.
Also the tests are wrong and hide a logic error introduced by the
recent changes to support DNS TXT records. I posted a patch for this a
moment ago

https://www.redhat.com/archives/libvir-list/2011-June/msg01423.html

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]