[libvirt] [PATCH 1/9] Fix crash when aborting a stream from a I/O callback
Eric Blake
eblake at redhat.com
Tue Jun 28 17:39:41 UTC 2011
On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
> If a callback being invoked from a stream issues a virStreamAbort
> operation, the stream data will be free'd but the callback will
> then stil try to use this. Delay free'ing of the stream data when
s/stil/still/
> a callback is dispatching
>
> * src/fdstream.c: Delay stream free when callback is active
> ---
> src/fdstream.c | 33 +++++++++++++++++++++++----------
> 1 files changed, 23 insertions(+), 10 deletions(-)
>
> cb(stream, events, cbopaque);
>
> virMutexLock(&fdst->lock);
> - fdst->dispatching = 0;
> + fdst->dispatching = false;
> if (fdst->cbRemoved && ff)
> (ff)(cbopaque);
cb is called without locks, while ff is still under the lock. No change
from previous status quo, but I wonder if ff should ever be moved
outside the lock.
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110628/f717627f/attachment-0001.sig>
More information about the libvir-list
mailing list