[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 3/9] Lower logging level when failing to register socket watch



On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
> The RPC client treats failure to register a socket watch
> as non-fatal, since we do not mandate that a libvirt client
> application provide an event loop implementation. It is
> thus inappropriate to a log a message at VIR_LOG_WARN
> 
> * src/rpc/virnetsocket.c: Lower logging level
> ---
>  src/rpc/virnetsocket.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index 68d7de7..96d2dfd 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/rpc/virnetsocket.c
> @@ -1066,7 +1066,7 @@ int virNetSocketAddIOCallback(virNetSocketPtr sock,
>                                           virNetSocketEventHandle,
>                                           sock,
>                                           NULL)) < 0) {
> -        VIR_WARN("Failed to register watch on socket %p", sock);
> +        VIR_DEBUG("Failed to register watch on socket %p", sock);

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]