[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 4/9] Ensure empty payload is written upon stream completion



On 06/28/2011 11:01 AM, Daniel P. Berrange wrote:
> On stream completion it is neccessary to send back a

s/neccessary/necessary/ (must be one of your finger-memory typos ;)

> message with an empty payload. The message header was
> not being filled out correctly, since we were not writing
> any payload. Add a method for encoding an empty payload
> which updates the message headers correctly.
> 
> * src/rpc/virnetmessage.c, src/rpc/virnetmessage.h: Add
>   a virNetMessageEncodePayloadEmpty method
> * src/rpc/virnetserverprogram.c: Write empty payload on
>   stream completion
> ---
>  src/rpc/virnetmessage.c       |   25 +++++++++++++++++++++++++
>  src/rpc/virnetmessage.h       |    2 ++
>  src/rpc/virnetserverprogram.c |    5 ++++-
>  3 files changed, 31 insertions(+), 1 deletions(-)
> 

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]