[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: Don't expect translatable strings in a dead file



On 06/28/2011 01:22 PM, Jiri Denemark wrote:
> daemon/remote_dispatch_bodies.h is no longer with us and shouldn't be
> searched for translatable strings.
> ---
> Pushed under the build-breaker rule.

ACK; however, this patch is incomplete.

> +++ b/po/POTFILES.in
> @@ -1,6 +1,5 @@
>  daemon/libvirtd.c
>  daemon/remote.c
> -daemon/remote_dispatch_bodies.h
>  daemon/stream.c
>  gnulib/lib/gai_strerror.c
>  src/conf/cpu_conf.c

We still have translated strings in a new file,
daemon/remote_dispatch.h.  I'm pushing this followup:

diff --git i/cfg.mk w/cfg.mk
index b7929e1..69f35a3 100644
--- i/cfg.mk
+++ w/cfg.mk
@@ -31,7 +31,7 @@ gnulib_dir = $(srcdir)/.gnulib
 # List of additional files that we want to pick up in our POTFILES.in
 # This is all gnulib files, as well as generated files for RPC code.
 generated_files = \
-  $(srcdir)/daemon/*_dispatch_*.h \
+  $(srcdir)/daemon/*_dispatch.h \
   $(srcdir)/src/remote/*_client_bodies.h \
   $(srcdir)/src/remote/*_protocol.[ch] \
   $(srcdir)/gnulib/lib/*.[ch]
diff --git i/po/POTFILES.in w/po/POTFILES.in
index 1f226fd..32eaa2d 100644
--- i/po/POTFILES.in
+++ w/po/POTFILES.in
@@ -1,5 +1,6 @@
 daemon/libvirtd.c
 daemon/remote.c
+daemon/remote_dispatch.h
 daemon/stream.c
 gnulib/lib/gai_strerror.c
 src/conf/cpu_conf.c

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]