[libvirt] [PATCH] Fix compliation with systemtap 1.3
Eric Blake
eblake at redhat.com
Tue Jun 28 22:47:22 UTC 2011
s/compliation/compilation/ in the subject
On 06/28/2011 04:34 PM, Matthias Bolte wrote:
> Version 1.3 uses this macro
version 1.3 of <sys/sdt.h>
>
> #define STAP_CAST(t) (size_t)t
>
> that breaks if t is a function. For that to work it should probably
> look like this
>
> #define STAP_CAST(t) ((size_t)(t))
For the record, this is what Matthias posted on IRC:
remote.c:1775: error: cast from function call of type 'const char *' to
non-matching type 'long unsigned int' [-Wbad-function-cast]
>
> In systemtap 1.4 this was completely rewritten.
>
> Anyway, before commit df0b57a95a767c t was always a variable, but now
> also a function is used here, namely virNetSASLSessionGetIdentity.
>
> Use an intermediate variable to avoid this problem.
> ---
> daemon/remote.c | 17 +++++++++--------
> 1 files changed, 9 insertions(+), 8 deletions(-)
ACK.
--
Eric Blake eblake at redhat.com +1-801-349-2682
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 619 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20110628/d4782670/attachment-0001.sig>
More information about the libvir-list
mailing list