[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] network: Fix dnsmasq hostsfile creation logic and related tests



2011/6/28 Eric Blake <eblake redhat com>:
> On 06/28/2011 05:10 AM, Matthias Bolte wrote:
>> networkSaveDnsmasqHostsfile was added in 8fa9c2214247 (Apr 2010).
>> It has a force flag. If the dnsmasq hostsfile already exists force
>> needs to be true to overwrite it. networkBuildDnsmasqArgv sets force
>> to false, networkDefine sets it to true. This results in the
>> hostsfile being written only in networkDefine in the common case.
>> If no error occurred networkSaveDnsmasqHostsfile returns true and
>> networkBuildDnsmasqArgv adds the --dhcp-hostsfile to the dnsmasq
>> command line.
>
> Thanks for the detailed commit message - it was a huge help in reviewing.
>
> The patch is a bit big, but it fixes both a real code problem and the
> remaining test failure, so it is appropriate for inclusion in 0.9.3.
>
> ACK.
>

Thanks, pushed.

-- 
Matthias Bolte
http://photron.blogspot.com


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]