[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: simplify sanlock distribution



Eric Blake <eblake redhat com> writes:

> EXTRA_DIST is intended for files that must unconditionally be
> part of the tarball, so it should be outside HAVE_SANLOCK.
> Once that is fixed, then there is no need to cp an unchanged
> qemu-sanlock.conf from srcdir to builddir in a VPATH build,
> not to mention that $(builddir) is not supported in the automake
> in use in RHEL 5.

The way that EXTRA_DIST honors Automake conditionals is, in my
opinion, surprising.  In some of my own projects, I've just added
        noinst_HEADERS += $(EXTRA_DIST)
outside any Automake conditional to fix that.  When you do that,
any file mentioned in EXTRA_DIST is always distributed,
regardless of conditionals.

See also:
http://lists.gnu.org/archive/html/automake/2009-07/msg00049.html
http://lists.gnu.org/archive/html/automake/2009-07/msg00051.html
-- 
Ben Pfaff 
http://benpfaff.org


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]