[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] build: simplify sanlock distribution



On 06/29/2011 03:38 AM, Daniel P. Berrange wrote:
>> -
>> -$(builddir)/locking/%-sanlock.conf: $(srcdir)/locking/sanlock.conf
>> -	$(AM_V_GEN)mkdir locking ; \
>> -	cp $< $@
> 
> How does  'qemu-sanlock.conf' get created now ? This rule is what actually
> tells make how to create 'qemu-sanlock.conf' from 'sanlock.conf'

Serves me right for coding too late at night.

I guess you have a point - you want to ship sanlock.conf as a template,
as well as install multiple <HV>-sanlock.conf files, one for each <HV>
that supports sanlock (right now, just qemu), while still storing only
one file in libvirt.git.  I missed the '%-' in the rule in my first read
of it.

In which case, my patch is wrong.  But the existing code is also wrong -
the EXTRA_DIST still needs to be moved outside of HAVE_SANLOCK, and the
'mkdir' needs to instead be '$(MKDIR_P)' for parallel builds.

v2 coming up.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]