[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] SIGTERM undeclared, virNetSocketFree



On 06/30/2011 08:53 AM, Daniel P. Berrange wrote:
> On Thu, Jun 30, 2011 at 07:36:24AM -0700, Jason Helfman wrote:
>> Hi,
>>
>> I get this error when compiling 0.9.3-rc2 on FreeBSD. Is there a fix for
>> this?

> We're using 'kill' without explicitly including signal.h. I suspect
> we're lucky to get it indirectly on Linux. Try this patch
> 
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index 96d2dfd..7e63d78 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/rpc/virnetsocket.c
> @@ -27,6 +27,7 @@
>  #include <sys/socket.h>
>  #include <unistd.h>
>  #include <sys/wait.h>
> +#include <signal.h>

ACK.

[Odd - I have found that glibc has generally been striving for less
namespace pollution, so it's a bit surprising that we have a case where
glibc leaks a symbol but FreeBSD does not]

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]