[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Fix leak of virStreamPtr object with callback added in fdstream impl



On 06/30/2011 06:14 AM, Daniel P. Berrange wrote:
> When adding a callback to an FD stream, we take an extra reference
> on the virStreamPtr instance. We forgot to registered a free function
> with the callback, so when the callback was removed, the extra
> reference held on virStreamPtr was not released.
> 
> * src/fdstream.c: Use a free callback to release reference on
>   virStreamPtr when removing callback
> ---
>  src/fdstream.c |    9 ++++++++-
>  1 files changed, 8 insertions(+), 1 deletions(-)

ACK.

-- 
Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]