[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] build: consistently use CFLAGS

On 06/30/2011 05:12 PM, Laine Stump wrote:
> On 06/30/2011 02:09 PM, Eric Blake wrote:
>> According to the automake manual, CPPFLAGS (aka INCLUDES, as spelled
>> in automake 1.9.6) should only include -I, -D, and -U directives; more
>> generic directives like -Wall belong in CFLAGS since they affect more
>> phases of the build process.  Therefore, we should be sticking CFLAGS
>> additions into a CFLAGS container, not a CPPFLAGS container.
>> * src/Makefile.am (INCLUDES): Move CFLAGS items...
>> (AM_CFLAGS): ...to their proper location.
>> * python/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
>> * tests/Makefile.am (INCLUDES, AM_CFLAGS): Likewise.
>> ---
> ACK.

Hmm, my testing is showing that I've probably botched something over a
month of rebasing, and I'll need a v3 to fix a compilation error from an
unfound header.

Eric Blake   eblake redhat com    +1-801-349-2682
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]